-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lokiexporter: Support dynamic attributes for labels #2290
Comments
@andrewhsu - Could you assign this to me? |
@bogdandrutu - Could you assign this to me? |
Hello, I'm pretty according with you it could be an non default option. Maybe it can be also a workaround for another bug I faced with lokiexporters and attributes with uppercase chars impossible to whitelist (more details here : open-telemetry/opentelemetry-collector#2594, the root cause seems dispatched in 2 new other issues) |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
cc @mar4uk |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
probably this configuration should work:
transform processor can be used to filter attributes, resource processor can be used to promote attributes to loki labels. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@gramidt will fixing this issues/19215 solve your case? |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I'm closing, as this doesn't seem to be relevant anymore. If the issue @mar4uk linked isn't enough to satisfy this use-case and if there's still interest in this, please leave a comment and I'll reopen. |
Is your feature request related to a problem? Please describe.
The Loki exporter by design forces a user to explicitly configure the attributes they want to allow as labels within Loki. This is a safety net to help prevent accidentally adding dynamic labels that may significantly increase cardinality, thus having a performance impact on their Loki instances. However, users may trust their downstream configurations, such as Fluentd or Stanza, to keep labels to a minimum.
Describe the solution you'd like
As a Loki user, I want to be able to filter attributes and have the exporter dynamically transform them into valid Loki labels, so that downstream systems do not have to sync their attributes within the exporter config.
Describe alternatives you've considered
The text was updated successfully, but these errors were encountered: