Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/awscloudwatchmetrics] [2/2] final implementation of receiver #23562

Closed
wants to merge 12 commits into from
Closed

[receiver/awscloudwatchmetrics] [2/2] final implementation of receiver #23562

wants to merge 12 commits into from

Conversation

lewis262626
Copy link
Member

@lewis262626 lewis262626 commented Jun 19, 2023 •
edited
Loading

Description:

AWS cloudwatch metrics final implementation. Fixes #15667

Link to tracking Issue:

#15667

Testing:

Unit and integration testing

Documentation:

README.md

@github-actions github-actions bot requested review from jpkrohling and kovrus June 19, 2023 21:41
@lewis262626 lewis262626 mentioned this pull request Jun 19, 2023
Open
2 tasks
@lewis262626 lewis262626 changed the title [receiver/awscloudwatchmetricsreceiver] [2/2] final implementation [receiver/awscloudwatchmetricsreceiver] [2/2] WIP: final implementation Jun 19, 2023
@lewis262626 lewis262626 changed the title [receiver/awscloudwatchmetricsreceiver] [2/2] WIP: final implementation [receiver/awscloudwatchmetrics] [2/2] WIP: final implementation Jun 19, 2023
@lewis262626 lewis262626 force-pushed the implement_receiver branch from 9d952b5 to 254bb8d Compare July 4, 2023 17:34
@jpkrohling
Copy link
Member

Please ping us when this is ready to be reviewed.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@jpkrohling
Copy link
Member

@lewis262626, is this ready for review?

@lewis262626
Copy link
Member Author

@lewis262626, is this ready for review?

I've been meaning to finish this off, but I'm on holiday without access to my laptop.

Should be ready by early August. There are a few bugs from what I can remember

@jpkrohling
Copy link
Member

jpkrohling commented Jul 28, 2023 •
edited
Loading

Sounds good, move this out of draft when ready please.

@github-actions github-actions bot removed the Stale label Jul 28, 2023
@lewis262626 lewis262626 changed the title [receiver/awscloudwatchmetrics] [2/2] WIP: final implementation [receiver/awscloudwatchmetrics] [2/2] final implementation of receiver Aug 9, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 24, 2023
@github-actions github-actions bot removed the Stale label Aug 29, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 15, 2023
@ceevaaa
Copy link

ceevaaa commented Sep 18, 2023 •
edited
Loading

Hey guys, is this completed and merged ?
@jpkrohling

@github-actions github-actions bot removed the Stale label Sep 19, 2023
@lewis262626
Copy link
Member Author

Hey guys, is this completed and merged ?
@jpkrohling

Still need to finish off final testing, apologies

@ceevaaa
Copy link

ceevaaa commented Sep 27, 2023

Hey guys, is this completed and merged ?
@jpkrohling

Still need to finish off final testing, apologies

No worries. Thanks for all the efforts brother <3.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 18, 2023
korenyoni
korenyoni reviewed Nov 1, 2023
View reviewed changes
receiver/awscloudwatchmetricsreceiver/receiver.go
Comment on lines +279 to +286
input := &cloudwatch.ListMetricsInput{
Namespace: aws.String(auto.Namespace),
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to add support for monitoring accounts via IncludeLinkedAccounts?

As per: #15667 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate PR, yes.

@github-actions github-actions bot removed the Stale label Nov 2, 2023
@michael-burt
Copy link
Contributor

Hi @lewis262626 is this PR still being worked on?

@lewis262626
Copy link
Member Author

Hi @lewis262626 is this PR still being worked on?

Yes, just didn't have any motivation to finish this off. I just have the integration tests to write, then should be done

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 18, 2023
@ceevaaa
Copy link

ceevaaa commented Dec 18, 2023

@lewis262626 how much work is left ?

@JonathanPartain
Copy link

@lewis262626 Any plans on continuing this work? I am quite interested in this, so I'll gladly help if you want, despite my limited knowledge of go 😄

@jaslkaur29
Copy link

Hi, does anyone know when it will be available for use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni left review comments

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@kovrus kovrus Awaiting requested review from kovrus

Assignees
No one assigned
Labels
receiver/awscloudwatchmetrics Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New component: AWS CloudWatch metrics receiver
7 participants
@lewis262626 @jpkrohling @ceevaaa @michael-burt @JonathanPartain @jaslkaur29 @korenyoni