Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] Add resource getters #26690

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Add metadata map for pod and container requests and limits. Will be used to calculate new metrics in a future PR.

Link to tracking Issue:
#24905

Testing:
added unit tests

@TylerHelmuth TylerHelmuth requested a review from a team September 14, 2023 16:55
@TylerHelmuth TylerHelmuth force-pushed the kubeletstats-resource-maps branch from c2d8114 to 0cb858a Compare September 14, 2023 17:00
@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 14, 2023
@TylerHelmuth TylerHelmuth force-pushed the kubeletstats-resource-maps branch from 0cb858a to 477b974 Compare September 14, 2023 17:04
@TylerHelmuth TylerHelmuth force-pushed the kubeletstats-resource-maps branch from 477b974 to 4e3c4c7 Compare September 14, 2023 17:44
@TylerHelmuth
Copy link
Member Author

@dmitryax ready for another review

@TylerHelmuth
Copy link
Member Author

@dmitryax ready for another review

@dmitryax
Copy link
Member

Just a nit, don't want to block this anymore

@TylerHelmuth TylerHelmuth merged commit dbde606 into open-telemetry:main Sep 26, 2023
91 checks passed
@TylerHelmuth TylerHelmuth deleted the kubeletstats-resource-maps branch September 26, 2023 19:04
@github-actions github-actions bot added this to the next release milestone Sep 26, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:**
Add metadata map for pod and container requests and limits. Will be used
to calculate new metrics in a future PR.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#24905

**Testing:** <Describe what testing was performed and which tests were
added.>
added unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/kubeletstats Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants