[exporter/datadog] Update span_name_remappings examples

[hanikesn]

Component(s)

exporter/datadog

What happened?

Description

The examples use outdated behavior and do not give expected results. The expected format is # "otel.library.name/ScopeName"."span.kind" See:

opentelemetry-collector-contrib/exporter/datadogexporter/examples/collector.yaml

Lines 318 to 321 in a257d0f

	# span_name_remappings:
	# io.opentelemetry.javaagent.spring.client: spring.client
	# instrumentation:express.server: express
	# go.opentelemetry.io_contrib_instrumentation_net_http_otelhttp.client: http.client

Collector version

0.95

Environment information

No response

OpenTelemetry Collector configuration

exporters:
  datadog:
    traces:
      span_name_remappings:
        # "otel.library.name"."span.kind"
        "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho.server": echo.server
        "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.client": http.client
        "go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.client": grpc.client
        "go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.server": grpc.server

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

@hanikesn Can you share where you're getting the expected format from?

I looked into it a bit and the span_name_remappings configuration option is being mapped to the Datadog agent's configuration option of the same name. The comment there is that the variable is used to map from the Datadog span name to the preferred name. The examples you've referenced also currently match what is given in the config file.

I think the existing example may be correct based on this information, but the code owners would have a definitive answer here.

[hanikesn]

@hanikesn Can you share where you're getting the expected format from?

That was mostly by trial and error until I got the expected result in the Datadog UI.

I think the existing example may be correct based on this information

Unfortunately those didn't work and I spent quite some time figuring our the correct format. Others share the same confusion:
#1909 (comment)
And see this comment suggesting to update the examples as well:
DataDog/datadog-agent#12176 (comment)

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[hanikesn]

I can confirm that even with the latest datadog agent (7.54) and using DD_OTLP_CONFIG_TRACES_SPAN_NAME_REMAPPINGS:
You have to use:

"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.server": "grpc.server"

instead of:

"go.opentelemetry.io_contrib_instrumentation_google.golang.org_grpc_otelgrpc.server": "grpc.server",

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr @ankitpatel96

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr @ankitpatel96

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[hanikesn]

Not stale

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr @ankitpatel96 @jade-guiton-dd

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[IbraheemA]

We'll be introducing new operation name logic soon which will deprecate span_name_remappings once the new logic is in stable. I can go ahead and update the examples in the meantime