Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

severity_parser: update docs to correct overwrite_text name #36102

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

davispuh
Copy link
Contributor

I was wondering why severity_parser wasn't updating severity_text
Turns out documentation is wrong and overwrite_text is correct name for this functionality.

@davispuh davispuh requested review from djaglowski and a team as code owners October 30, 2024 23:51
Copy link

linux-foundation-easycla bot commented Oct 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: davispuh / name: Dāvis (129b067)
  • ✅ login: djaglowski / name: Daniel Jaglowski (7afeea9)

@djaglowski
Copy link
Member

Closing in favor of the #36103

@djaglowski djaglowski closed this Oct 31, 2024
@davispuh
Copy link
Contributor Author

#36103 is not a superset of this PR. There is additional place where wrong name is used which is fixed with this PR. See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/docs/operators/severity_parser.md

I'm just very lazy and edited it with GitHub UI and that's why 2 PRs because changed 2 separate files.

@monoxono
Copy link
Contributor

monoxono commented Jan 2, 2025

Hi @djaglowski, as @davispuh said, the fix in this PR is in file pkg/stanza/docs/operators/severity_parser.md and it's different from #36103 where pkg/stanza/docs/types/severity.md got fixed.
Could you please check it? Thanks.

@djaglowski djaglowski reopened this Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.18%. Comparing base (2e60343) to head (129b067).
Report is 479 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36102      +/-   ##
==========================================
+ Coverage   80.15%   81.18%   +1.02%     
==========================================
  Files        2179     2246      +67     
  Lines      204875   226889   +22014     
==========================================
+ Hits       164227   184199   +19972     
- Misses      35303    36953    +1650     
- Partials     5345     5737     +392     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 6, 2025
@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Jan 8, 2025
@djaglowski djaglowski merged commit 1f2d608 into open-telemetry:main Jan 9, 2025
180 of 181 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/stanza ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants