-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
severity_parser: update docs to correct overwrite_text name #36102
Conversation
`overwrite_text` is correct name
Closing in favor of the #36103 |
#36103 is not a superset of this PR. There is additional place where wrong name is used which is fixed with this PR. See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/docs/operators/severity_parser.md I'm just very lazy and edited it with GitHub UI and that's why 2 PRs because changed 2 separate files. |
Hi @djaglowski, as @davispuh said, the fix in this PR is in file |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36102 +/- ##
==========================================
+ Coverage 80.15% 81.18% +1.02%
==========================================
Files 2179 2246 +67
Lines 204875 226889 +22014
==========================================
+ Hits 164227 184199 +19972
- Misses 35303 36953 +1650
- Partials 5345 5737 +392 ☔ View full report in Codecov by Sentry. |
I was wondering why
severity_parser
wasn't updatingseverity_text
Turns out documentation is wrong and
overwrite_text
is correct name for this functionality.