Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/prometheusremotewrite] Flaky test #36654

Open
ArthurSens opened this issue Dec 3, 2024 · 4 comments
Open

[receiver/prometheusremotewrite] Flaky test #36654

ArthurSens opened this issue Dec 3, 2024 · 4 comments

Comments

@ArthurSens
Copy link
Member

Component(s)

receiver/prometheusremotewrite

Describe the issue you're reporting

I've just noticed we have some flaky tests in main: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12146357038/job/33870088465

=== FAIL: . TestComponentLifecycle/metrics-lifecycle (0.00s)
    generated_component_test.go:65: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusremotewritereceiver/generated_component_test.go:65
        	Error:      	Received unexpected error:
        	            	failed to create prometheus remote-write listener: listen tcp 127.0.0.1:9090: bind: address already in use
        	Test:       	TestComponentLifecycle/metrics-lifecycle

=== FAIL: . TestComponentLifecycle (0.00s)

=== FAIL: . TestHandlePRWContentTypeNegotiation/no_content_type (0.00s)
    receiver_test.go:90: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusremotewritereceiver/receiver_test.go:90
        	Error:      	Received unexpected error:
        	            	Post "http://localhost:9090/api/v1/write": dial tcp [::1]:9090: connect: connection refused
        	Test:       	TestHandlePRWContentTypeNegotiation/no_content_type

=== FAIL: . TestHandlePRWContentTypeNegotiation (0.00s)
    receiver_test.go:[43](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12146357038/job/33870088465#step:7:44): 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusremotewritereceiver/receiver_test.go:36
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusremotewritereceiver/receiver_test.go:43
        	Error:      	Received unexpected error:
        	            	failed to create prometheus remote-write listener: listen tcp 127.0.0.1:9090: bind: address already in use
        	Test:       	TestHandlePRWContentTypeNegotiation
@ArthurSens ArthurSens added the needs triage New item requiring triage label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ArthurSens
Copy link
Member Author

/label -needs-triage

@github-actions github-actions bot removed the needs triage New item requiring triage label Dec 4, 2024
@dashpole
Copy link
Contributor

dashpole commented Dec 4, 2024

maybe we need to change tests to use a random port?

@ArthurSens
Copy link
Member Author

Yeah, that's probably enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants