Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate antonmedv/expr for use in filters and transforms #5887

Closed
punya opened this issue Oct 25, 2021 · 3 comments
Closed

Evaluate antonmedv/expr for use in filters and transforms #5887

punya opened this issue Oct 25, 2021 · 3 comments
Assignees

Comments

@punya
Copy link
Member

punya commented Oct 25, 2021

#5680 introduces a DSL for filtering logs, and based on prior discussions we want to consider a similar approach for metric transforms/filters too. Before committing to this approach and this library, we'd like to do a deeper evaluation:

  • overall performance impact of evaluating DSL at runtime
  • comparison with other DSL approaches
  • can we handle filter for resource && inst lib && signal without evaluating resource multiple times

Thanks @bogdandrutu for the detailed suggestion. Please add any other evaluation criteria that are on your mind.

@bogdandrutu
Copy link
Member

I made a prototype in the past using other library open-telemetry/opentelemetry-collector#2408

@pmalek-sumo
Copy link
Contributor

Is there anyone working on this? Have we done any of the research mentioned in the description?

@punya
Copy link
Member Author

punya commented Jan 31, 2022

My apologies for not working on this issue. However, in light of @anuraaga's work on a generic transform processor (design doc, WIP implementation), I believe this evaluation is no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants