From 3c123867191dfadc4e03074791a720b3f2d876ee Mon Sep 17 00:00:00 2001 From: abhishek-at-cloudwerx Date: Fri, 11 Oct 2024 13:30:56 +0530 Subject: [PATCH 1/3] refactor: - Remove redundant TODO lines from googlecloudmonitoringreceiver receiver component --- receiver/googlecloudmonitoringreceiver/receiver.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/receiver/googlecloudmonitoringreceiver/receiver.go b/receiver/googlecloudmonitoringreceiver/receiver.go index 4b0d6b256e20..5b230831ba26 100644 --- a/receiver/googlecloudmonitoringreceiver/receiver.go +++ b/receiver/googlecloudmonitoringreceiver/receiver.go @@ -314,8 +314,6 @@ func (mr *monitoringReceiver) convertGCPTimeSeriesToMetrics(metrics pmetric.Metr mr.metricsBuilder.ConvertSumToMetrics(timeSeries, m) case metric.MetricDescriptor_DELTA: mr.metricsBuilder.ConvertDeltaToMetrics(timeSeries, m) - // TODO: Add support for HISTOGRAM - // TODO: Add support for EXPONENTIAL_HISTOGRAM default: metricError := fmt.Sprintf("\n Unsupported metric kind: %v\n", timeSeries.GetMetricKind()) mr.logger.Info(metricError) From a0e5a1ef01c9c14220e621083ed2c4b0e1b305b0 Mon Sep 17 00:00:00 2001 From: abhishek-at-cloudwerx Date: Sun, 13 Oct 2024 14:23:29 +0530 Subject: [PATCH 2/3] refactor: - Add changelog entry file for googlecloudmonitoringreceiver component --- ...ve-todo-googlecloudmonitoringreceiver.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .chloggen/remove-todo-googlecloudmonitoringreceiver.yaml diff --git a/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml b/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml new file mode 100644 index 000000000000..cdebef8ff42e --- /dev/null +++ b/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: bug_fix + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: googlecloudmonitoringreceiver + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Fix comments issue in googlecloudmonitoringreceiver receiver component + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [] From cd81810bc0691bb230ba748c1699483b15d028bc Mon Sep 17 00:00:00 2001 From: abhishek-at-cloudwerx Date: Sun, 13 Oct 2024 14:30:44 +0530 Subject: [PATCH 3/3] refactor: - Mention issue type in .chloggen file --- .chloggen/remove-todo-googlecloudmonitoringreceiver.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml b/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml index cdebef8ff42e..a5803edd2c19 100644 --- a/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml +++ b/.chloggen/remove-todo-googlecloudmonitoringreceiver.yaml @@ -10,7 +10,7 @@ component: googlecloudmonitoringreceiver note: Fix comments issue in googlecloudmonitoringreceiver receiver component # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. -issues: [] +issues: [35760] # (Optional) One or more lines of additional information to render under the primary note. # These lines will be padded with 2 spaces and then inserted directly into the document.