Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor telemetry should include Pipeline ID as attribute #10908

Closed
djaglowski opened this issue Aug 19, 2024 · 3 comments
Closed

Processor telemetry should include Pipeline ID as attribute #10908

djaglowski opened this issue Aug 19, 2024 · 3 comments
Labels
collector-telemetry healthchecker and other telemetry collection issues

Comments

@djaglowski
Copy link
Member

Is your feature request related to a problem? Please describe.

The processorhelper package defines several metrics but provides only a "Processor ID" attribute. This is insufficiently observable because a processor ID may apply to multiple instances of a processor. In effect, all instances of the processor configuration are reporting metrics as if they are the same instance.

Users should be able to understand the behavior of a processor within the context of each pipeline because the usage may be very different per pipeline.

As an example, suppose a processor used in two pipelines. In one pipeline, it reports 1000/1000 log records accepted, 0 for other metrics. In the other pipeline, it reports 10/10 log records rejected, 0 for all other metrics. Currently, the metric describes this as if 99% of data is being accepted by the processor. The reality that one pipeline is very healthy while the other is very unhealthy can easily be overlooked because of the lack of a pipeline ID attribute.

Describe the solution you'd like

Add a "Pipeline ID" attribute to all processor helper metrics.

Describe alternatives you've considered

This is proposed as an alternative to #10664, which would eliminate the need for the Pipeline ID attribute, but would introduce breaking changes elsewhere.

Additional Context

#10708 (comment)

@djaglowski djaglowski added the collector-telemetry healthchecker and other telemetry collection issues label Aug 19, 2024
@mx-psi mx-psi added this to the Self observability milestone Sep 11, 2024
@codeboten
Copy link
Contributor

Adding this information as an attribute makes sense to me, would be good to see what an implementation for this looks like

@djaglowski
Copy link
Member Author

I opened #11171 with a potential implementation.

@djaglowski
Copy link
Member Author

Closing in favor of #11343, which describes the appropriate attributes for all kinds of pipeline components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collector-telemetry healthchecker and other telemetry collection issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants