From bdfaf5db4a50495fa5c8b5b26867eb2e7c618451 Mon Sep 17 00:00:00 2001 From: Alex Boten <223565+codeboten@users.noreply.github.com> Date: Mon, 9 Sep 2024 09:39:22 -0700 Subject: [PATCH 1/2] [processorhelper] deprecating unused methods *Inserted was not used in the core/contrib repos, marking them as deprecated. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> --- processor/processorhelper/obsreport.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/processor/processorhelper/obsreport.go b/processor/processorhelper/obsreport.go index c69f601cf3d..05f485c3093 100644 --- a/processor/processorhelper/obsreport.go +++ b/processor/processorhelper/obsreport.go @@ -120,6 +120,8 @@ func (or *ObsReport) TracesDropped(ctx context.Context, numSpans int) { } // TracesInserted reports that the trace data was inserted. +// +// Deprecated: [v0.109.0] This method was not used in core/contrib and it's unclear when it should have been used. func (or *ObsReport) TracesInserted(ctx context.Context, numSpans int) { or.recordData(ctx, component.DataTypeTraces, int64(0), int64(0), int64(0), int64(numSpans)) } @@ -140,6 +142,8 @@ func (or *ObsReport) MetricsDropped(ctx context.Context, numPoints int) { } // MetricsInserted reports that the metrics were inserted. +// +// Deprecated: [v0.109.0] This method was not used in core/contrib and it's unclear when it should have been used. func (or *ObsReport) MetricsInserted(ctx context.Context, numPoints int) { or.recordData(ctx, component.DataTypeMetrics, int64(0), int64(0), int64(0), int64(numPoints)) } @@ -160,6 +164,8 @@ func (or *ObsReport) LogsDropped(ctx context.Context, numRecords int) { } // LogsInserted reports that the logs were inserted. +// +// Deprecated: [v0.109.0] This method was not used in core/contrib and it's unclear when it should have been used. func (or *ObsReport) LogsInserted(ctx context.Context, numRecords int) { or.recordData(ctx, component.DataTypeLogs, int64(0), int64(0), int64(0), int64(numRecords)) } From 3b7a30c1f8d584baab46629d5ba8ed4b8564bbc0 Mon Sep 17 00:00:00 2001 From: Alex Boten <223565+codeboten@users.noreply.github.com> Date: Mon, 9 Sep 2024 09:41:16 -0700 Subject: [PATCH 2/2] changelog Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> --- .../codeboten_deprecate-unused-methods.yaml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .chloggen/codeboten_deprecate-unused-methods.yaml diff --git a/.chloggen/codeboten_deprecate-unused-methods.yaml b/.chloggen/codeboten_deprecate-unused-methods.yaml new file mode 100644 index 00000000000..2edcbdd4f0e --- /dev/null +++ b/.chloggen/codeboten_deprecate-unused-methods.yaml @@ -0,0 +1,25 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: deprecation + +# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) +component: processorhelper + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: These funcs are not used anywhere, marking them deprecated. + +# One or more tracking issues or pull requests related to the change +issues: [11083] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: []