-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.EFCore] Support together with Instrumentation.SqlClient #2280
base: main
Are you sure you want to change the base?
[Instrumentation.EFCore] Support together with Instrumentation.SqlClient #2280
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
===========================================
- Coverage 73.91% 56.77% -17.15%
===========================================
Files 267 5 -262
Lines 9615 192 -9423
===========================================
- Hits 7107 109 -6998
+ Misses 2508 83 -2425
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please add CHANGELOG.md entry |
A test would be great as well! Is it possible to model a test for this fix? |
I will see what can be implemented 👍 |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Fixes #1764
Design discussion issue #
Changes
#1764 (comment)
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes