Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoexport: Rename IsNone to IsNoneSpanExporter #4133

Closed
pellared opened this issue Aug 2, 2023 · 2 comments · Fixed by #4134
Closed

autoexport: Rename IsNone to IsNoneSpanExporter #4133

pellared opened this issue Aug 2, 2023 · 2 comments · Fixed by #4134
Assignees
@pellared
Labels
area: exporter Related to an exporter package enhancement New feature or request
Milestone
v0.43.0

Comments

@pellared
Copy link
Member

pellared commented Aug 2, 2023 •
edited
Loading

IsNone should to be renamed to IsNoneSpanExporter as there may be an equivalent reader/exporter for metrics in future.

Originally posted by @pellared in #4132 (comment)

Note: Do not forget to also update the docs [IsNone] -> [IsNoneSpanExporter] as I am not sure if gorename handles it.
@pellared pellared changed the title autoexport: Rename IsNone to IsNoneSpanExporter or remove it autoexport: Rename IsNone to IsNoneSpanExporter Aug 2, 2023
@pellared pellared added enhancement New feature or request area: exporter Related to an exporter package labels Aug 2, 2023
@pellared pellared self-assigned this Aug 2, 2023
@pellared pellared mentioned this issue Aug 2, 2023
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Aug 2, 2023

We should prioritize this to happen before the next release.

@MrAlias MrAlias added this to the v0.42.0 milestone Aug 2, 2023
@pellared
Copy link
Member Author

pellared commented Aug 2, 2023

We should prioritize this to happen before the next release.

I plan to create a PR on Monday.

@pellared pellared mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area: exporter Related to an exporter package enhancement New feature or request
Projects
None yet
Milestone
v0.43.0
Development

Successfully merging a pull request may close this issue.

autoexport: Rename IsNone to IsNoneSpanExporter pellared/opentelemetry-go-contrib
2 participants
@pellared @MrAlias