Trace id changes while creating custom span

[balkrishan333]

For adding business information to my spans I am creating a manual span (this is because I think I can't add attributes to span obtained by Span.current()) and adding required information to that but I noticed that my default span and span which I created manually have different trace ids. I was expecting trace id for both to be same. I am using following code to create manual span

        OpenTelemetry openTelemetry = OpenTelemetryFactory.getInstance();
        Tracer tracer = openTelemetry.getTracer("");

        Span parentSpan = Span.current();
        Span span = tracer.spanBuilder("balkrishan span").setParent(Context.current().with(parentSpan))
                .setSpanKind(SpanKind.SERVER).startSpan();

        span.setAttribute("messageType", "v2");
        span.setAttribute("tenant", "dummy tenant");
       
        // put the span into the current Context
        try (Scope scope = span.makeCurrent()) {
            // app code
             
        } catch (Throwable t) {
            span.setStatus(StatusCode.ERROR, "Change it to your error message");
        } finally {
            span.end(); // closing the scope does not end the span, this has to be done manually
        }

I am using jaeger as visualisation tool. I can see both the spans in jaeger but trace id for both of them is different.
Please help me identify what I am doing wrong or is my expectation that trace id should be same unfair.

Just to be clear, when I say default span, my method's entry point is "/tracing" and I can see 1 span with name "/tracing" and another one named "balkrishan span" as created by code above.

[jkwatson]

1. You definitely can add attributes to an existing Span.
2. Since there is already a Span in the current Context, you don't need to put it in again when parenting your new span. Just don't manually specify a parent on your new Span and it'll use the one already in the current Context.

[balkrishan333]

Hi

I got it working. After upgrading the javaagent version, I needed to make some changes in parameter names. Once correct parameter names where used, everything is working as per expectation. My original problem of different trace id with 2 spans is also solved. Only thing is GlobalOpenTelemetry does not work for me.

Thanks for all your support.

[jkwatson]

Have you updated your example code with the example of GlobalOpenTelemetry not being properly initialized by the javaagent?

[balkrishan333]

I am not sure what you meant but I have used followed code while trying to use GlobalOpenTelemetry

        OpenTelemetry globalOpenTelemetry = GlobalOpenTelemetry.get();
        Tracer tracer = globalOpenTelemetry.getTracer("");

Do you mean I need to take care of some initiailization in order to use GlobalOpenTelemetry

[jkwatson]

no, I was looking at the example you provided, and it still had SDK initialization code in it, so I assume you hadn't updated it for me to see what problem you might be encountering.

[balkrishan333]

Yeah, you are right. When trying with GlobalOpenTelemetry I didn't realize that I am initialising the SDK and just tried to use GlobalOpenTelemetry after removing calls to SDK opentelemetry object. Just now I tried with GlobalOpenTelemetry after removing the initialization code for SDK and it works without any problem.

Thanks for your help.