-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quite some issues in the Java manual instrumentation doc #3765
Comments
Thanks for raising this issue, @brightzheng100!
good point. I assume the same applies for the getting started then.
Yes, that's a minor thing that should be fixable (there's a
If you know the exact issues, feel free to fix them via a PR.
See #3229 for this. This is a mix of old docs (no roll the dice app) and new docs (with roll the dice app). So far nobody took the time and effort to fix this.
It's a reference documentation that provides you with an example throughout the documentation. That's at least the goal. Unfortunately the docs team is very limited in bandwidth to complete this. So we appreciate any help to close those gaps. @open-telemetry/java-approvers PTAL |
I am +1 for this question. raise a PR for fix this.
I am -1 for this.
I am -1 for 4. due to opentelemetry target to collabrate logging, trace, metrics in distributed environment. it will be much easier if we have a minimal web app there. |
I think the issue here is that the wrong version is applied:
should become
Yes, this docs just need some love and attention, as outlined in #3229, similar to #3853, Java needs a continued flow for metrics |
What needs to be changed? Describe the update that is required.
When trying to quickly walk through the Java manual instrumentation doc here, I found a series of issues even I haven't completely walked it through yet:
mavenCentral()
, and definesio.opentelemetry:opentelemetry-semconv:1.34.1-alpha
as one of the dependencies, but actually the latest version in Maven Central of that lib is1.30.1-alpha
. Luckily, if we follow carefully we'd realize that it's just some typo thingy as the later section will use the right libs.In short, if it's a reference doc, focus on the capabilities / features and how to use them; if it's a tutorial with a given example, the example must be suitable to demonstrate most, if not all capabilities / features, and then make it a complete workable project.
The text was updated successfully, but these errors were encountered: