Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Metrics Documentation could use an update #4123

Closed
jaydeluca opened this issue Mar 11, 2024 · 3 comments · Fixed by #4165
Closed

Java Metrics Documentation could use an update #4123

jaydeluca opened this issue Mar 11, 2024 · 3 comments · Fixed by #4165
Labels
bug Something isn't working sig:java

Comments

@jaydeluca
Copy link
Member

jaydeluca commented Mar 11, 2024

I would like to re-write the Java Metrics documentation to follow a format similar to other languages, and include missing information on Exporters, Readers, and Views.

What needs to be changed?

The current java instrumentation -> metrics documentation is missing a lot of information. As a new user who wants to start using java OpenTelemetry metrics, there is not enough information provided on this page to actually get started. Right now it only provides a brief introduction to the different instrument types supported, with very basic code examples.

Other languages like Go, C++ and Javascript follow a more in depth and organized structure / content that cover several things that the current java documentation doesn't include.

I plan to re-write this section of the java documentation to follow the structure of:

  • Intro
  • Initialize Metrics (MeterProvider)
  • Acquiring a Meter
  • Using Counters
  • Using UpDown Counters
  • Using Histograms
  • Using Observable (Async) Counters
  • Using Observable (Async) UpDown Counters
  • Using Observable (Async) Gauges
  • Adding Attributes
  • Metric Views

Path of the page that needs changed?

https://opentelemetry.io/docs/languages/java/instrumentation/#metrics

Additional Context / Notes

I wasn't sure if I should open this issue in the opentelemetry-java repo or this one, if I need to do anything else before contributing this change, please let me know.

@jaydeluca jaydeluca added the bug Something isn't working label Mar 11, 2024
@svrnm
Copy link
Member

svrnm commented Mar 11, 2024

Hey @jaydeluca, thanks for raising this issue and offering your help, this is the right place to ask for this (although I cc @open-telemetry/java-approvers for visibility).

Please go ahead and provide these updates to the Instrumentation Documentation, all I ask you to do is use the JavaScript and other documentation that is already in place as a blueprint for your additions. We try to create consistent documentation across languages right now, such that most of the non-code part of the documentation is the same, see
#3229

@svrnm svrnm added the sig:java label Mar 11, 2024
@trask
Copy link
Member

trask commented Mar 12, 2024

yes ❤️❤️❤️

@breedx-splk
Copy link
Contributor

Came here to also say thanks @jaydeluca ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sig:java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants