Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] Localize otel-localized announcement page to Portuguese (Brazil) #5035

Merged
merged 7 commits into from
Aug 23, 2024
Merged

[pt] Localize otel-localized announcement page to Portuguese (Brazil) #5035

merged 7 commits into from
Aug 23, 2024

Conversation

pedroespindula
Copy link
Contributor

@pedroespindula pedroespindula commented Aug 13, 2024 •
edited
Loading

Waiting for #4996 to be merged.

Add localization for annoucement page for OTel localization.

Issue: #4922 and #4863

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pedroespindula pedroespindula force-pushed the otel-localized-pt branch 4 times, most recently from dee8036 to 7349b22 Compare August 14, 2024 00:47
@pedroespindula pedroespindula changed the title [pt-br] Localize otel-localized announcement page to Portuguese (Brazil) [pt] Localize otel-localized announcement page to Portuguese (Brazil) Aug 14, 2024
lgfa29
lgfa29 reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo trabalho @pedroespindula!

content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Show resolved Hide resolved
content/pt/blog/2024/docs-localized.md Outdated Show resolved Hide resolved
@ymotongpoo ymotongpoo mentioned this pull request Aug 15, 2024
Merged
@theletterf
Copy link
Member

@pedroespindula The announcement should go live today ideally. Could you have a look at the feedback please?

chalin
chalin requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. This PR will need to be rebased, have conflicts resolved, and then force-pushed.

@ymotongpoo ymotongpoo mentioned this pull request Aug 21, 2024
Closed
@pedroespindula pedroespindula force-pushed the otel-localized-pt branch 3 times, most recently from 6782428 to 986e657 Compare August 21, 2024 15:12
@pedroespindula pedroespindula marked this pull request as ready for review August 21, 2024 15:16
@pedroespindula pedroespindula requested a review from a team August 21, 2024 15:16
@pedroespindula
Copy link
Contributor Author

@pedroespindula The announcement should go live today ideally. Could you have a look at the feedback please?

Hi. This PR will need to be rebased, have conflicts resolved, and then force-pushed.

Hey, @theletterf and @chalin!

Thanks for the heads up! I have updated the PR according to the feedbacks and rebased the PR. Also, I made the PR Ready for Review.

Also, thanks for the review @lgfa29!

Cc: @edsoncelio

edsoncelio
edsoncelio reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!
LGTM

edsoncelio
edsoncelio reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@EzzioMoreira
Copy link
Contributor

LGTM 🆗
Parabéns pela iniciativa @pedroespindula 👏

@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10504228510

@theletterf
Copy link
Member

@chalin This seems green now!

@edsoncelio edsoncelio mentioned this pull request Aug 22, 2024
Open
26 tasks
@chalin
Copy link
Contributor

chalin commented Aug 22, 2024

@open-telemetry/docs-pt-approvers - please (GH) approve

chalin
chalin approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Awaiting official approval from @open-telemetry/docs-pt-approvers before merging.

@edsoncelio
Copy link
Member

@emdneto
image

@chalin
Copy link
Contributor

chalin commented Aug 22, 2024

@open-telemetry/docs-maintainers - any idea why @open-telemetry/docs-pt-approvers / maintainers isn't a choice in the Reviewers request dropdown?

image

@chalin chalin mentioned this pull request Aug 22, 2024
Closed
@lmolkova lmolkova requested review from a team and removed request for lgfa29 August 22, 2024 21:40
@opentelemetrybot opentelemetrybot requested review from a team August 22, 2024 23:13
@chalin
Copy link
Contributor

chalin commented Aug 23, 2024

Merging on @emdneto's approval.

@chalin chalin added this pull request to the merge queue Aug 23, 2024
Merged via the queue into open-telemetry:main with commit 5868790 Aug 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsoncelio edsoncelio edsoncelio left review comments

@lgfa29 lgfa29 lgfa29 left review comments

@emdneto emdneto emdneto approved these changes

@chalin chalin chalin approved these changes

@theletterf theletterf theletterf approved these changes

@EzzioMoreira EzzioMoreira Awaiting requested review from EzzioMoreira

Assignees
No one assigned
Labels
blog lang:pt
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pedroespindula @theletterf @EzzioMoreira @opentelemetrybot @chalin @edsoncelio @lgfa29 @emdneto