[outreachy] updated registry with inline help tooltips #5450
+51
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @svrnm I have made another PR with the changes and the correct files to work on as per our last discussion. |
svrnm
changed the title
svrnm
reviewed
Oct 24, 2024
| @@ -34,10 +34,54 @@ | |||
| {{ end -}} | |||
| {{ $types = $types | uniq | sort -}} | |||
|
|
|||
| <!--Custom css for the inline help--> | |||
There was a problem hiding this comment.
Please move custom CSS into this file:
https://github.com/open-telemetry/opentelemetry.io/blob/main/assets/scss/_registry.scss
Doing so, make sure that the CSS is only applied on that page, e.g. right now if we use "btn-outline-success" class on any other page the hover::after would also be applied
There was a problem hiding this comment.
Thanks mentor I will update it.
There was a problem hiding this comment.
Please make sure that you provide the update today, such that I still can review it. I will not be available for more feedback afterwards until the end of the application phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #5420. I implemented hover hints on key action buttons to make clear to users what they can expect when they click these buttons. The buttons show users exactly how to interact with different parts of the OpenTelemetry registry.
I also added a hover hint on the alert text that describes what OpenTelemetry Registry is, further describing what the Telemetry is, without leaving the page itself.
Example of the hover hint in one of the action buttons.
Hover hint in the alert description