From 799b215afa7eb28f40ef20d7c742d0f58b4b2700 Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Mon, 8 Jul 2024 12:36:38 -0700 Subject: [PATCH] more feedback --- docs/dotnet/dotnet-network-traces.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/dotnet/dotnet-network-traces.md b/docs/dotnet/dotnet-network-traces.md index 5940aa3f2c..65080bbc6a 100644 --- a/docs/dotnet/dotnet-network-traces.md +++ b/docs/dotnet/dotnet-network-traces.md @@ -14,8 +14,8 @@ This article defines semantic conventions for HTTP client, DNS and TLS spans emi - [HTTP client request: wait for connection](#http-client-request-wait-for-connection) - [HTTP connection setup](#http-connection-setup) - [Socket connect](#socket-connect) -- [DNS](#dns) -- [TLS](#tls) +- [DNS](#dns-resolution) +- [TLS](#tls-handshake) - [Examples](#examples) - [HTTP request was performed on a connection that was immediately available](#http-request-was-performed-on-a-connection-that-was-immediately-available) - [HTTP request has to wait for connection setup](#http-request-has-to-wait-for-connection-setup) @@ -102,7 +102,7 @@ The `{address}` SHOULD be `server.address` when it's available and `network.peer Span kind SHOULD be `CLIENT`. -Corresponding `Activity.OperationName` is `System.Net.Http.Connections.ConnectionSetup`, `ActivitySource` name - `System.Net.Http.Connections` TODO - should be different than connection? +Corresponding `Activity.OperationName` is `System.Net.Http.Connections.ConnectionSetup`, `ActivitySource` name - `System.Net.Http.Connections`. Added in .NET Core 9.