-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should system
metrics be renamed to os
(for consistency with attributes)?
#1371
Comments
I assume it could still be |
Similarly we have I assume the same applies for the
We would need some concrete use cases to change the current model which is widely used extensively by the Collector users. |
We discussed this at KubeCon NA 2024 at 2024-11-14. We think we should keep things as is but document what each namespace is meant for. |
Removing system blocker label (since it is already at the parent issue) |
closing in favor of a better description to be added in #1578 |
We have
os.name
,os.version
, type, etc attributes, but usesystem
on metrics (system.cpu.time
,system.memory.usage
, etc).System metrics are effectively OS metrics:
semantic-conventions/docs/system/system-metrics.md
Lines 14 to 15 in 5eb37f7
We should consider renaming
system
toos
(i.e. (os.cpu.time
, ...) for the sake of consistency.Also I'd expect system metrics to be reported with
os
resource (it's useful to know the OS type when interpreting specific metric), but it's not documented.The text was updated successfully, but these errors were encountered: