-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chloggen should generate links for PRs #1627
Comments
There could be a way of doing it today, with a custom template https://github.com/open-telemetry/opentelemetry-go-build-tools/blob/main/chloggen/internal/chlog/testdata/custom.tmpl#L5 the only problem is that it's not possible to distinguish between a issue or a PR, since the field today can hold numbers for both. To really make it work, we would need in chloggen another field for the PR number. I've sent a proposal, let's see 🤞. In the PR there's an example on how we can generate the PR links in the markdown file. |
Alright, I was unaware that GitHub automatically redirects correctly PRs/Issues, so we don't need changes in the tool. Just a custom template.
Source: https://docs.github.com/en/rest/using-the-rest-api/issue-event-types?apiVersion=2022-11-28 thanks @mowies ! |
Changelog contains PR numbers which are not automatically recognized as links when they are committed to the repo.
semantic-conventions/CHANGELOG.md
Line 15 in 07293ed
It'd be great to make chloggen produce links for them.
The text was updated successfully, but these errors were encountered: