-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db.cluster namespace for RDBs #858
Comments
Once I'm advised on how to proceed here, I can open a PR to add it to the conventions. I just wanted to ask for guidance here. Thanks in advance! |
A couple of questions:
|
Hello, a cluster is a collection of multiple servers that all have the same cluster name. For example, we may have a We plan to send this information based on the queries being set in our application, as exception metadata. It would be set while reporting other details in an exception. I am not sure if that answers your second question. |
so, if I understand correctly, this attribute is intended for your own manual instrumentation within your application? The reason I'm asking is that most of attributes defined in DB semconv are populated by instrumentation libraries automatically without knowing any application specific details. I'm trying to understand what's the value (to you) of adding this very specific manually populated attribute to semconv (given it can be changed, removed, deprecated, etc in the future) instead of documenting one within your project. |
We will go ahead with defining our own .cluster.name attribute. We were just trying to standardize given other things fit into the |
Area(s)
area:db
Is your change request related to a problem? Please describe.
We'd like to be able to standardize in our services on an attr for naming MySQL clusters. This should just be a short name identifier, not a hostname+port. And it is not a specific instance (we have many instances in one cluster.)
Describe the solution you'd like
The two things we've discussed are
db.cluster.name
or something namespaced (like ElasticSearch does withdb.elasticsearch.cluster.name
) asdb.mysql.cluster.name
. But this could also be more generally applied to RDBs beyond just MySQL, and it would still mean the same thing.Describe alternatives you've considered
As described above. Alternatively we have a number of internal apps using our own namespace and variations like:
namespace.db
-- too short to indicate what's in itnamespace.db.connection.cluster.name
-- verbosenamespace.env
-- confusingly, this was actually cluster names internally, and so we need to work with them to change it either way.But I'm hoping to propose and get a
db.*
namespaced attr that we can all agree on, to standardize these use cases on.Additional context
Prior art: #345 for our instances, but now we need to identify MySQL clusters by name.
The text was updated successfully, but these errors were encountered: