add rocksdb.swift #5 #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Jul 22, 2024
| do { | ||
| db = try RocksDB(path: path, prefix: prefix) | ||
| } catch { | ||
| throw NSError(domain: Database.errorDomain, code: 2, userInfo: [NSLocalizedDescriptionKey: "Failed to init RocksDB: \(error)"]) |
There was a problem hiding this comment.
don't use NSError.
use something like
public enum Error: Swift.Error {
case initFailed,
case notOpen,
}and throw Error. initFailed
There was a problem hiding this comment.
but in this case, there is no need to do anything, just do catch it and let the error propagate will be fine
| public class Database { | ||
| public let path: URL | ||
| public let prefix: String? | ||
| private var db: RocksDB? |
There was a problem hiding this comment.
I don't think we need to make db optional.
Comment on lines
39
to
43
| do { | ||
| return try type.init(data: db.get(key: key)) | ||
| } catch { | ||
| throw error | ||
| } |
Comment on lines
58
to
59
| keyType _: Key.Type, | ||
| valueType _: Value.Type, |
Database/Tests/LinuxMain.swift
Outdated
| @@ -0,0 +1,7 @@ | |||
| import XCTest | |||
There was a problem hiding this comment.
no need to have this, swift test should just work
| @@ -0,0 +1,9 @@ | |||
| import XCTest | |||
xlc
reviewed
Jul 22, 2024
Comment on lines
7
to
8
| public let path: URL | ||
| public let prefix: String? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.