👷 [maykinmedia/objects-api#463] Add trivy image scan #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/re-enable-trivy-image-scan
branch
3 times, most recently
from
7b1c941
to
1ee864e
Compare
stevenbal
force-pushed
the
feature/re-enable-trivy-image-scan
branch
3 times, most recently
from
8bc6ab1
to
18b9fd7
Compare
|
@annashamray I can't run the cache update job yet because it's not on main yet |
annashamray
requested changes
Nov 1, 2024
.github/workflows/trivy.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: Call Update Trivy Cache | |||
There was a problem hiding this comment.
Sorry a little nitpicking. Correct me if I'm wrong but this workflow doesn't trigger trivy scan, it just cached the DB, right?
So maybe let's rename it to trivy-db-cache of something like this?
stevenbal
force-pushed
the
feature/re-enable-trivy-image-scan
branch
from
18b9fd7
to
b362cfd
Compare
annashamray
requested changes
Nov 18, 2024
|
|
||
| jobs: | ||
| call-update-trivy-cache: | ||
| uses: maykinmedia/open-api-workflows/.github/workflows/ci.yml@v3 |
There was a problem hiding this comment.
Suggested change
| uses: maykinmedia/open-api-workflows/.github/workflows/ci.yml@v3 | |
| uses: maykinmedia/open-api-workflows/.github/workflows/trivy.yml@v3 |
Shouldn't it a specific workflow?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/objects-api#463 partially