-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::complex #203
Comments
yep, i need this for wavefront data. any progress here? |
We haven't started working on this yet. I defend in a week from now, little time to look into this right now but maybe you can store it interleaved like we do it for the thetaMode geometry?
Of course, thoughts and PRs are welcome as well :)
|
ok, interleaving should work. good luck for next week!
|
For the interested reader of this issue that would like to work on this: Then, e.g. starting with HDF5, one defines new types in the backends such as In ADIOS1 (https://github.com/ornladios/ADIOS/search?q=complex&unscoped_q=complex) as well as ADIOS2, complex data types are supported by default: https://adios2.readthedocs.io/en/latest/components/components.html#variables-data-types In JSON we probably just write a |
Implementation started in #639 |
The implementation is mainly done, just waiting for a new ADIOS2 release to be tagged. We contributed support for complex types in attributes: ornladios/ADIOS2#1908 |
Add support for complex numbers as fundamental data type. Close #203 - [x] Tests - [x] internals: new types, comparisons, allowed casts, record components, patches and attributes, etc. - [x] JSON (writes to pairs, read re-identification as complex is todo) - [x] HDF5 - [x] ADIOS1 (no long double complex; no attributes of arrays of complex: ornladios/ADIOS#212) - [x] ADIOS2: (complex attributes: ornladios/ADIOS2#1908); (no long double complex ornladios/ADIOS2#1907) - [x] Python bindings
Standardization agreed upon and documented here: openPMD/openPMD-standard#29 (comment) #639 adds the implementation in the API and will be shipped with the next release, openPMD-api 0.12.0. |
Although not part of the openPMD standard yet, handling of types for
std::complex< T >
withfloat
,double
andlong double
could be investigated.Keep in mind:
h5py
: http://docs.h5py.org/en/latest/faq.htmlThe text was updated successfully, but these errors were encountered: