Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Chakracore.dll & .lib is not copied automatically, sometimes. #6

Open
sanjaiganesh opened this issue Aug 1, 2016 · 3 comments
Open

Comments

@sanjaiganesh
Copy link

Repro:

  1. Clean build for ia32 first.
    node .\build.js --url_node=https://github.com/munyirik/node --cid_node=chakra-uwp --reset
  2. now build for x64 (without --reset)
    node .\build.js --url_node=https://github.com/munyirik/node --cid_node=chakra-uwp --dest-cpu=x64

See that chakracore.dll is not copied automatically.

@sanjaiganesh sanjaiganesh changed the title Chakracore.dll is not copied automatically, sometimes. Chakracore.dll & .lib is not copied automatically, sometimes. Aug 1, 2016
@obastemur
Copy link
Contributor

obastemur commented Aug 2, 2016

https://github.com/openT2T/node-apphost/blob/master/build.js#L106
node-chakracore uses chakracore tag while node-uwp uses old chakra tag. Probably that will be fixed with the latest PR on ms-iot node. @munyirik ?

@munyirik
Copy link

munyirik commented Aug 3, 2016

chakra-uwp builds node-chakra so it uses Chakra.dll on the system and not ChakraCore.dll. This means that it shouldn't get copied at all. But you're seeing it get copied sometimes?

@sanjaiganesh
Copy link
Author

hmm. ok. May be I have mixed the builds that left chakracore.dll when building node-chakracore (chakracore-master) and incorrectly deduced. I shall verify this.

@obastemur obastemur removed their assignment Aug 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants