Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with capacity assertions being out of order in test suite results #638

Open
lukehesluke opened this issue Feb 21, 2024 · 3 comments
Assignees

Comments

@lukehesluke
Copy link
Contributor

Fix issue relating to the order of test results within a test suite output page - sometimes the errors are not related to the relevant JSON output which can be confusing

@lukehesluke lukehesluke self-assigned this Feb 21, 2024
@lukehesluke lukehesluke converted this from a draft issue Feb 21, 2024
@lukehesluke lukehesluke changed the title Fix bug with capacity assertions being out of order in test suite results (this bug may already be logged) Fix bug with capacity assertions being out of order in test suite results Feb 21, 2024
@lukehesluke lukehesluke moved this from 🏗 In progress to 🔖 Ready for team in OpenActive Infrastructure Feb 21, 2024
@lukehesluke
Copy link
Contributor Author

Nick believes that this happens only when C2/B fail. In these instances, the capacity assertion logs come out in the wrong order. First step: reproduce

@lukehesluke lukehesluke moved this from 🔖 Ready for team to 🏗 In progress in OpenActive Infrastructure Feb 21, 2024
@lukehesluke
Copy link
Contributor Author

@nickevansuk I've tried the following things:

  • Forcing an error at B by creating an invalid request
  • Forcing an error at B by just throwing a random error
  • Forcing an error at the assert opportunity capacity stage by expecting an incorrect capacity
  • And likewise all of the above for C2

And in all cases, the capacity assertion log appears to be in the right place in the output .md file

Image

@lukehesluke lukehesluke moved this from 🏗 In progress to Ready for Nick in OpenActive Infrastructure Feb 21, 2024
@nickevansuk
Copy link
Collaborator

@lukehesluke have you tried a validation error at C2 or B, and seeing where that validation error is displayed (was that what "invalid request" above meant?)? Noting that validation errors and test failures are handled differently.

@nickevansuk nickevansuk moved this from Ready for Nick to 🔖 Ready for team in OpenActive Infrastructure Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready for team
Development

No branches or pull requests

2 participants