Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book-and-seller-replace-items test should assert that capacity changes as expected after a replacement #671

Open
lukehesluke opened this issue Mar 25, 2024 · 0 comments

Comments

@lukehesluke
Copy link
Contributor

If a booked opportunity is replaced for another one, then the capacity of the old one should go back up and the capacity of the new one should go down by one

Notes to implementer

Look at packages/openactive-integration-tests/test/features/cancellation/seller-requested-replacement/implemented/book-and-seller-replace-items-test.js

You can see that there's some commented out code that starts to implement this capacity assertion, but it's commented out. I don't know why it's commented out. Some options:

  • It doesn't work because there's an issue with OpenActive.Server.NET's BookingSystem.AspNetCore. In which case, fix that
  • It was commented out because the logic is tricky and it was incomplete. In which case, fix this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💡Ideas
Development

No branches or pull requests

1 participant