Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions ubuntu version (22 -> 24) #697

Open
lukehesluke opened this issue Oct 15, 2024 · 0 comments
Open

Upgrade GitHub Actions ubuntu version (22 -> 24) #697

lukehesluke opened this issue Oct 15, 2024 · 0 comments

Comments

@lukehesluke
Copy link
Contributor

lukehesluke commented Oct 15, 2024

In this PR: #696, I fixed ubuntu version from ubuntu-latest to ubuntu-22.04. This is because a change appears to have happened in Ubuntu which leads to this error:

Screenshot 2024-10-15 at 13 27 56 (1)

Process terminated. Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.

(link to the whole run)

Downgrading to 22.04 fixed this

What's going on

This is what I have gathered so far:

  • Adding this step to the tests job (in .github/workflows/reference-implementation.yml) before the Install OpenActive.Server.NET dependencies step may fix it as it will install an ICU package:
    # These are required for .NET globalization
    - name: Install ICU packages
      run: |
        sudo apt-get update
        sudo apt-get install -y libicu-dev
  • Or alternatively setting:
    env:
      DOTNET_SYSTEM_GLOBALIZATION_INVARIANT: 1
    in the test may fix it but will turn off globalization (https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization)

But it might also be worth finding out why a Ubuntu upgrade might have caused this. Is everyone having to do one of these additional steps in order to run .NET now? Maybe there's a more canonical solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant