Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor feed-checker.js to use feed-page-checker.js #29

Open
nickevansuk opened this issue Apr 3, 2023 · 0 comments
Open

Refactor feed-checker.js to use feed-page-checker.js #29

nickevansuk opened this issue Apr 3, 2023 · 0 comments

Comments

@nickevansuk
Copy link
Contributor

Ensure that feed-checker.js uses feed-page-checker.js, and that it therefore runs this line of logic for all rules:

const isItemDuplicationPermissible = isInitialHarvestComplete || cacheControlComponents.public;

This will ensure that the Cache Control errors are not displayed in the Validator GUI for feeds where a cache is in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant