Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add south korea #1090

Merged
merged 17 commits into from
Mar 19, 2024
Merged

Add south korea #1090

merged 17 commits into from
Mar 19, 2024

Conversation

majesticio
Copy link
Contributor

South Korea air quality data from 'Korea Air' with ~650 stations. This adapter is a bit slow so it currently has its own deployment.

Some breaking changes include update to our custom request client with updates to all the adapter that use it. The client us more robust, with error handling, and will only retry on errors other the timeouts, which were causing problems with the fetch lambdas not being able to finish if an adapter timed out and retried 3 times. You can also pass url, params, headers, timeout, retries, method, responseType and https to the client. url is the only required param and makes a GET request and parses JSON by default. If the responseType expected is text, that needs to be declared

@majesticio majesticio requested a review from caparker March 15, 2024 19:43
  Many of our adapters where not handling errors correctly and
  therefor they would occasionally get hung up.
@caparker caparker merged commit 82aa807 into main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants