Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect enum associations in Dimm interface #8

Open
kellycouch opened this issue Feb 11, 2020 · 1 comment
Open

Incorrect enum associations in Dimm interface #8

kellycouch opened this issue Feb 11, 2020 · 1 comment
Assignees

Comments

@kellycouch
Copy link

\openbmc\phosphor-dbus-interfaces\xyz\openbmc_project\Inventory\Item\Dimm.interface.yaml

Contains two enums: Type and DeviceType.

Currently, enum DeviceType is associated with property MemoryType and enum Type is not associated with any property.

Both are incorrect. See SMBIOS specification which these are intended to align with.

Current:

- name: MemoryType
  type: enum[self.DeviceType]
  description: >
      Type of memory.
- name: MemoryTypeDetail
  type: string
  description: >
      Additional detail on Memory, such as Synchronous, Static column, etc.

Proposed:

- name: MemoryType
  type: enum[self.Type]
  description: >
      Type of memory.
- name: MemoryTypeDetail
  type: enum[self.DeviceType]
  description: >
      Additional detail on Memory, such as Synchronous, Static column, etc.
@bradbishop
Copy link
Member

Hi @cyang29 do you care to comment on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants