Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not create a new Series #132

Closed
mic-men opened this issue Jan 25, 2023 · 10 comments
Closed

Can not create a new Series #132

mic-men opened this issue Jan 25, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@mic-men
Copy link
Contributor

mic-men commented Jan 25, 2023

Update from 7.3.2023: Bug is fixed, still missing is the implementation of some specification (see comment #132 (comment))

Describe the bug
A new series can not be created.
(Video upload and playing in existing series is possible with no problems.)

To Reproduce
Steps to reproduce the behavior:
Try to create new Opencast Series in ILIAS (Existing Series: no)
The error occurs independently of set metadata like mentioned in #131 .
The error occurs appearently in the plugin before a creation is tried in Opencast.
In ILIAS remains an empty non-accessible Opencast series object which can not be deleted!

Log
Error thrown with message "Call to a member function addToAcls() on null"

Stacktrace:
#10 Error in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.ilObjOpenCastGUI.php:422
#9 ilObjOpenCastGUI:afterSave in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/Object/classes/class.ilObjectGUI.php:1032
#8 ilObjectGUI:saveObject in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.ilObjOpenCastGUI.php:368
#7 ilObjOpenCastGUI:save in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/Repository/classes/class.ilObjectPluginGUI.php:149
#6 ilObjectPluginGUI:executeCommand in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.ilObjOpenCastGUI.php:196
#5 ilObjOpenCastGUI:executeCommand in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/UICore/classes/class.ilCtrl.php:217
#4 ilCtrl:forwardCommand in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/Repository/classes/class.ilRepositoryGUI.php:375
#3 ilRepositoryGUI:show in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/Repository/classes/class.ilRepositoryGUI.php:337
#2 ilRepositoryGUI:executeCommand in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/UICore/classes/class.ilCtrl.php:217
#1 ilCtrl:forwardCommand in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/Services/UICore/classes/class.ilCtrl.php:178
#0 ilCtrl:callBaseClass in /var/www/vhosts/lms-public.uni-tuebingen.de/httpdocs/ilias3/ilias.php:23

Environment (please complete the following information):

  • ILIAS version: ILIAS (v7.16 2022-11-24)
  • PHP version: PHP 7.4.3
  • Plugin version: 5.1.0
  • Opencast version: 10.13.0
  • Browser: Firefox
  • Only the basic OpenCast Plugin is used, nothing else (like Events).
@mic-men mic-men added the bug Something isn't working label Jan 25, 2023
@okaufman
Copy link
Contributor

okaufman commented Jan 25, 2023

Hello I have a question.
In the Plugin-Config under "Video Portal" -> "Permission Templates"
Do you have any templates configured? Is one template selected as the default template?

@mic-men
Copy link
Contributor Author

mic-men commented Jan 25, 2023

Yes there are templates configured. Honestly I dont'know who had done this. In our main system still running the old plugin, there are no such templates.
The template configuration looks like this:
1.
Titel: Zugriff für alle authentifizierten Nutzer ueber AAI
Rolle: ROLE_USER
Leserechte: yes ; Schreibrechte: No
All other columns: nothing
2.
Titel: Anonymer Zugriff
Rolle: ROLE_ANONYMOUS
Leserechte: yes ; Schreibrechte: No
All other columns: nothing

None of them is set as default.
When I change this and set 1. as default, it's working! A series can be created!

Question: What is the effect of this setting?
Should I set the write permission to yes? What would be the effect of that?
Or are the template settings a mistake at all?
I need to understand this - if the templates are needed I may have to add them on our plugin in the main ILIAS.
Thanks for clarification.

@ckozianka
Copy link

Hi, we are experiencing the same problem. And we have no permission templates for video portal configured because we have no video portal.
Best regards
Carsten

@okaufman
Copy link
Contributor

Hello
Right now the plugin only works, if you have at least one template configured and set as default. This is a bug and we will work on it.

Right know as a workaround, you can create a template and set it as default. You have to give the template a name and a role. The role can be anything. You just don't add any permissions for that role.

@dagraf
Copy link

dagraf commented Jan 30, 2023

When taking care of this bug please consider:
At the moment the 'default template' does not get shown when the option "Publish Series on Video Portal" gets activated when creating a series. This leads to the fact, that if you only configure one default template (because the current state of the plugins forces you to do so) the option "Publish Series on Video Portal" is empty when it gets activated during the creation of a series (see screenhsot).

Bildschirmfoto 2023-01-30 um 16 52 27

Expected behavior:

  • The default template does not get shown. This is allready the case.
  • If only the default template is configured the option "Publish Series on Video Portal" does NOT get offered while creating and editing series.
  • In plugin config:
    • In the subtab "Permission Templates" change the description below the title "Permission Templates" to: "All but the default template can be chosen from when creating or editing a series. If a template gets chosen, the configured role with the given permissions and actions will be set on the series. The roles of the residual templates will be removed."
    • Change the description of the setting "Default Template" to: "This template will be used if the series should not be published to the external video portal. Therefore, only one template can be defined as the default template. This template can not be chosen when creating or editing series. Do not set a default template if you don't want to set roles and actions for series which do not get published to the video portal."

@ckozianka
Copy link

Hi, your workaround works, thank you very much.

BTW: On our installation the template checkbox is displayed...
Unbenannt

Kind regards
Carsten

@ckozianka
Copy link

ckozianka commented Jan 31, 2023

Checking it during creation of the series has no effect and it does not get stored. Checking it in an existing OC object leads to "Error when communicating with Opencast server".

@dagraf
Copy link

dagraf commented Feb 2, 2023

Checking it during creation of the series has no effect and it does not get stored. Checking it in an existing OC object leads to "Error when communicating with Opencast server".

Could the latter be due to the bug described here #131? We were able to solve this with UNchecking the option "Read-Only" in the fields for "creator" and "contributer" (see subtab "Series" in the new tab "Metadata").

@okaufman okaufman mentioned this issue Feb 8, 2023
@dagraf
Copy link

dagraf commented Feb 22, 2023

Thx for the fix, the bug does not exist anymore. I leave the issue open as the specifications mentioned in this comment are not yet implemented. This will follow later.

@dagraf
Copy link

dagraf commented Mar 29, 2023

I created a new ticket containing the specifications of this comment. Therefore, I close this ticket.

@dagraf dagraf closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants