Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Opencast object can be selected on a course page using the manage and then copy functions #386

Closed
ubRudolf opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ubRudolf
Copy link

ubRudolf commented Dec 19, 2024

Describe the bug
Although an Opencast Object can only be linked on an ILIAS platform, it can be selected and "copied" on a course page using the "Manage" and "Copy" functions. In the case of our ILIAS platforms, this has very unpleasant consequences. At the destination, several hundred additional videos from different owners appear in the copied series! They seem to be "selected" at random. In one case, two videos from a series were included and two others were not. All 4 videos were published at the same time with the same rights. There were videos from a period of four years. These videos can be played and also “deleted”. As a result, the publication of the original also disappears!

To Reproduce
Steps to reproduce the behavior:

  1. Go to a course with an Opencast object
  2. Click on "Content" and then on "Manage" in the submenu.
  3. Choose the Opencast object per check mark
  4. Click the "copy" Button on the top of all objects
  5. Choose another course and insert the OC object.
  6. Open the "copied" series.

Expected behavior
It should not be possible to choose an Opencast object with the described function because OC objects could only be linked!

Screenshots
If applicable, add screenshots to help explain your problem.

Log
If you have it please attach the relevant log.

Environment (please complete the following information):

  • ILIAS version: [8.15]
  • PHP version: [8.0.30]
  • Plugin version: [8.2.2]
  • Opencast version [14.6]
  • Browser: [all]

Additional context
Add any other context about the problem here.

@dagraf
Copy link

dagraf commented Jan 7, 2025

Thx for the bugreport @ubRudolf. I can reproduce this issue on our platform.

@chfsx: Can you please have a look at it as soon as possible? This is a major bug. Thx!

@chfsx
Copy link
Contributor

chfsx commented Jan 13, 2025

The plugin itself already "defines" that copy should not be possible. ILIAS seems to ignore that, I tried to track this down in ILIAS Core but just found a lot of old code and was not able to find the right place where this should be checked in ILIAS. This PR provides a workaround: while checking permissions, the plugin now always returns false for the copy-permission. this at least prevents from generating (non-functions) copies of Opencast objects in ILIAS.

see PR in #388

@dagraf dagraf moved this from Ready to Testing in Opencast & Opencast PageComponent Jan 13, 2025
@dagraf
Copy link

dagraf commented Feb 18, 2025

Since #388 got merged I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants