Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: coserver shell handling is broken. opencog/cogserver#3 #2413

Open
linas opened this issue Dec 2, 2019 · 4 comments
Open

Python: coserver shell handling is broken. opencog/cogserver#3 #2413

linas opened this issue Dec 2, 2019 · 4 comments

Comments

@linas
Copy link
Member

linas commented Dec 2, 2019

Python printing in the cogserver shell is (was??) broken, due to changes in PythonEval in the atomspace. For details, see opencog/cogserver#3

@linas
Copy link
Member Author

linas commented Dec 2, 2019

@noskill @vsbogd fyi

@linas linas added the python label Dec 2, 2019
@linas
Copy link
Member Author

linas commented Dec 2, 2019

See also opencog/cogserver#2 which might be a duplicate

@vsbogd vsbogd added the bug label Dec 3, 2019
@noskill
Copy link
Contributor

noskill commented Dec 6, 2019

Why cogserver uses PythonEval from atomspace? It can just call PyRun_InteractiveLoopFlags

@linas
Copy link
Member Author

linas commented Dec 6, 2019

Why?

History, I suppose. And simplicity. The Shell class is a generic class that takes one line of text input from, runs it, and then returns a text string. So it will work for "anything", and attaching it to PythonEval was easy.

We don''t quite have a good way of handing off the whole interactive loop to some handler; this is mostly due to the complexity of using boost::asio (which I'm unhappy about, because its .. complex, hard to use, and buggy.) I don't think it has an API where it can just hand off a socket to someone else to manage.

The cogserver python shell was used to communicate with ROS (since ROS is 90% python) but I don't think there are many (or any) unit tests for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants