Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, if the documents section is hidden for me, then I should not be able to click an upload link on the review page #8230

Open
onnee04 opened this issue Dec 17, 2024 · 2 comments

Comments

@onnee04
Copy link
Collaborator

onnee04 commented Dec 17, 2024

Bug description:
There is no scope to upload attendant signature as supporting document.

Steps to reproduce:

  1. Log in as Health worker/ reg agent/ registrar
  2. Fill up the notification form/ declaration form
  3. Land on Supporting Documents.

Actual result:
There is no field to provide attendant signature in supporting document page.

Expected result:
A field should be there to provide attendant signature in supporting document page.

Screenshot/ Recording:
as a reg agent

Attendant_sign_missing_reg_agent.mp4

as a health worker

Attendant_sign_missing_health_worker.mp4

Tested on:
https://login.niue.opencrvs.org/

Version:
V1.6.1

@onnee04 onnee04 added the Bug label Dec 17, 2024
@onnee04 onnee04 moved this from Backlog to Ready to build in OpenCRVS Core Dec 17, 2024
@onnee04 onnee04 moved this from Ready to build to Backlog in OpenCRVS Core Dec 17, 2024
@euanmillar
Copy link
Collaborator

@anninawersun I recall that we accepted this bug in the Niue health notifier form. Essentially it is a core bug. If the documents section is missing for a user, then upload button should not appear in the review page. @jpye-finch the Figma file for Niue is out of date as the supporting documents page should be hidden for the field agent. See the released code for this section: https://github.com/opencrvs/opencrvs-niue/blob/d8b7f10a2512fece0ff48f37b5124f1952eb2e81/src/form/birth/required-sections.ts#L207

@euanmillar euanmillar changed the title Unabale to upload attendant signature. As a user, if the documents section is hidden for me, then I should not be able to click an upload link on the review pagfe Dec 17, 2024
@euanmillar euanmillar changed the title As a user, if the documents section is hidden for me, then I should not be able to click an upload link on the review pagfe As a user, if the documents section is hidden for me, then I should not be able to click an upload link on the review page Dec 17, 2024
@euanmillar
Copy link
Collaborator

@onnee04 I changed the title. @anninawersun @jpye-finch I moved this to IET for prioritisation as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants