Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate 'red pepper' and 'red pepper flakes' #69

Open
jayaddison opened this issue Aug 2, 2023 · 1 comment
Open

Disambiguate 'red pepper' and 'red pepper flakes' #69

jayaddison opened this issue Aug 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jayaddison
Copy link
Member

Describe the bug
When searching for red pepper as an ingredient, many results that include red pepper flakes are returned, and those results are often irrelevant. It's not possible to filter those irrelevant results out currently, because red pepper flakes is not listed as an ingredient -- so it's not possible to enter it in the "ingredients to exclude" input box.

My understanding is that red pepper flakes are generally made from red chillis, while the term "red pepper" is used to refer to a form of bell pepper.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the homepage.
  2. Enter red pepper as an include ingredient.
  3. Observe that red pepper flakes cannot be entered as an exclude ingredient.
  4. Run a search.
  5. Observe that results including red pepper flakes are included in the results.

Expected behavior

  • Red pepper flakes should be identified as a separate ingredient (product) from red pepper, and should not belong underneath the bell pepper category in the ingredient hierarchy.

Screenshots
Here's the current configuration of the red pepper product in the Admin UI:

image

@jayaddison jayaddison added the bug Something isn't working label Aug 2, 2023
@jayaddison
Copy link
Member Author

Following some recipe recrawling and reindexing to the search engine, the situation is much improved.

The ingredient red pepper flakes has been extracted into a separate ingredient, and is searchable (and excludable) using the ingredient autosuggest input on the homepage.

The reindexing command was:

$ python recipes.py --where 'exists (select * from recipe_ingredients as ri where ri.recipe_id = recipes.id and ri.description ilike "%red pepper flakes%")' --recrawl

A few recipes seem to have failed to recrawl, so I'll keep this issue open until the reason for that is discovered and resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant