Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer Vision based Alpha Matting #2306

Merged
merged 11 commits into from
Mar 20, 2020
Merged

Computer Vision based Alpha Matting #2306

merged 11 commits into from
Mar 20, 2020

Conversation

sunitanyk
Copy link
Contributor

@sunitanyk sunitanyk commented Oct 24, 2019

This pullrequest changes resolves #2245, #2247

The results are now cleaner and in a state to be acceptable to be merged in OpenCV.

force_builders=linux,docs

@sunitanyk
Copy link
Contributor Author

@alalek The file alphamat_tutorial.markdown file is present under tutorials, but it is still giving the doxygen warning: /build/precommit-contrib_docs/build/doc/root.markdown:31: warning: unable to resolve reference to `alphamat' for \ref command

Please help how to fix it.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update!

root.markdown:31: warning: unable to resolve reference to `alphamat' for \ref command

This means that module's documentation is missing in .hpp files.
Similar to this is required.

modules/alphamat/include/opencv2/infoflow.hpp Outdated Show resolved Hide resolved
modules/alphamat/include/opencv2/infoflow.hpp Outdated Show resolved Hide resolved
modules/alphamat/CMakeLists.txt Outdated Show resolved Hide resolved
modules/alphamat/CMakeLists.txt Show resolved Hide resolved
modules/alphamat/samples/information_flow_matting.cpp Outdated Show resolved Hide resolved
modules/alphamat/tutorials/alphamat_tutorial.markdown Outdated Show resolved Hide resolved
modules/alphamat/tutorials/alphamat_tutorial.markdown Outdated Show resolved Hide resolved
modules/alphamat/tutorials/alphamat_tutorial.markdown Outdated Show resolved Hide resolved
modules/alphamat/tutorials/alphamat_tutorial.markdown Outdated Show resolved Hide resolved
modules/alphamat/src/intraU.cpp Outdated Show resolved Hide resolved
alpha matting code

This is a combination of 3 commits.

removed whitespaces

addressed issues raised in the PR

removed whitespaces
@sunitanyk
Copy link
Contributor Author

sunitanyk commented Feb 7, 2020

@alalek The state still in "Pending - Waiting for builds" for more than a day now. I have resolved all your initiated issues, except one(pls see above), and it has success in both 'linux' and 'docs' now. Can you help me resolve this and merge the code to OpenCV_contrib? Thank you !

@sunitanyk sunitanyk requested a review from alalek February 7, 2020 19:05
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

modules/alphamat/include/opencv2/alphamat.hpp Outdated Show resolved Hide resolved
modules/alphamat/include/opencv2/alphamat.hpp Outdated Show resolved Hide resolved
modules/alphamat/src/cm.cpp Outdated Show resolved Hide resolved
modules/alphamat/src/cm.hpp Outdated Show resolved Hide resolved
modules/alphamat/tutorials/alphamat_tutorial.markdown Outdated Show resolved Hide resolved
modules/alphamat/tutorials/alphamat_tutorial.markdown Outdated Show resolved Hide resolved
@asmorkalov asmorkalov self-requested a review March 20, 2020 11:28
@asmorkalov asmorkalov self-assigned this Mar 20, 2020
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek alalek merged commit 88c4ed0 into opencv:master Mar 20, 2020
@sunitanyk
Copy link
Contributor Author

@asmorkalov @alalek , the alphamat module is not being imported into the Python version of Opencv. I guess it needs a small change in the CMakeLists.txt file? Can we reopen this PR to make the changes and some updates to the documentation?

@alalek
Copy link
Member

alalek commented Sep 20, 2020

we reopen this PR

Feel free to prepare a new PR with necessary changes.

@wolterlw
Copy link

@sunitanyk still cannot import the module in Python (opencv-contrib-python-headless version 4.5.2). Is there any progress on this front?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants