-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computer Vision based Alpha Matting #2306
Conversation
@alalek The file alphamat_tutorial.markdown file is present under tutorials, but it is still giving the doxygen warning: /build/precommit-contrib_docs/build/doc/root.markdown:31: warning: unable to resolve reference to `alphamat' for \ref command Please help how to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for update!
root.markdown:31: warning: unable to resolve reference to `alphamat' for \ref command
This means that module's documentation is missing in .hpp files.
Similar to this is required.
alpha matting code This is a combination of 3 commits. removed whitespaces addressed issues raised in the PR removed whitespaces
@alalek The state still in "Pending - Waiting for builds" for more than a day now. I have resolved all your initiated issues, except one(pls see above), and it has success in both 'linux' and 'docs' now. Can you help me resolve this and merge the code to OpenCV_contrib? Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
- get rid of std::cout - remove clock_t - drop unnecessary cast: float pix = tmap.at<uchar>(i, j); - global 'dim' => 'ALPHAMAT_DIM' - fix sample command line handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@asmorkalov @alalek , the alphamat module is not being imported into the Python version of Opencv. I guess it needs a small change in the CMakeLists.txt file? Can we reopen this PR to make the changes and some updates to the documentation? |
Feel free to prepare a new PR with necessary changes. |
@sunitanyk still cannot import the module in Python (opencv-contrib-python-headless version 4.5.2). Is there any progress on this front? |
This pullrequest changes resolves #2245, #2247
The results are now cleaner and in a state to be acceptable to be merged in OpenCV.