Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error or more direct warning to deprecated "query" extension #611

Closed
robbibt opened this issue Jun 24, 2024 · 0 comments · Fixed by #615
Closed

Add error or more direct warning to deprecated "query" extension #611

robbibt opened this issue Jun 24, 2024 · 0 comments · Fixed by #615
Assignees

Comments

@robbibt
Copy link

robbibt commented Jun 24, 2024

The most recent version of Explorer no longer supports the "query" syntax (in favour of STAC's recommend "filter" syntax).

Although this is mentioned in a new warning from PySTAC, this is not very descriptive and doesn't explain that users should use "filter" instead:
image

This change risks users running into "silent failure" issues where they think that "query" is being applied when it is not (and getting back unfiltered data accidentally).

To avoid this, we should add either a hard error (forcing users to adapt their code to use "filter" instead), or a more descrptive warning message advising users to swap to "filter".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants