Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stac api item search extensions #570

Closed
wants to merge 2 commits into from
Closed

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Jan 11, 2024

Remedy some oversights from my previous work on stac api extensions:

  • support fields, sortby, and filter as GET request query parameters
  • remove conformance classes that weren't actually implemented (and don't need to be)
  • make extension handling logic more in line with the extension specifications

This is a band-aid fix; the entire stac api implementation needs to be reworked.


📚 Documentation preview 📚: https://datacube-explorer--570.org.readthedocs.build/en/570/

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (aa0d9f3) to head (4bebdc9).
Report is 75 commits behind head on develop.

Current head 4bebdc9 differs from pull request most recent head 2eb1fb4

Please upload reports for the commit 2eb1fb4 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #570      +/-   ##
===========================================
+ Coverage    86.29%   86.35%   +0.06%     
===========================================
  Files           26       26              
  Lines         3451     3511      +60     
===========================================
+ Hits          2978     3032      +54     
- Misses         473      479       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ariana-B Ariana-B linked an issue Mar 5, 2024 that may be closed by this pull request
@Ariana-B Ariana-B requested review from jeremyh and omad March 6, 2024 05:12
@Ariana-B Ariana-B marked this pull request as ready for review March 6, 2024 05:12
@omad
Copy link
Member

omad commented Jun 13, 2024

Merged in another PR

@omad omad closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants