Dockerfile: fail on errors #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #596 +/- ##
===========================================
- Coverage 86.29% 86.18% -0.12%
===========================================
Files 26 26
Lines 3451 3466 +15
===========================================
+ Hits 2978 2987 +9
- Misses 473 479 +6 ☔ View full report in Codecov by Sentry. |
Combine the RUN statements into a single statement. The Docker cache behavior remains the same, but there is one layer less in the produced image.
Combine the RUN statements into a single statement. The Docker cache behavior remains the same, but there is one layer less in the produced image.
Rewrite the if-then-else into short-circuiting tests followed by commands chained together with &&. This makes building the image fail if something is wrong, instead of giving strange errors when running the tests.
pjonsson
force-pushed
the
dockerfile-catch-errors
branch
from
a2d18cc to
eb9e481
Compare
omad
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge a couple of layers to slightly
reduce the image size, and
rewrite the if-then-else into
short-circuiting tests followed
by commands chained together
with &&. This makes building
the image fail if something is wrong,
instead of giving strange errors
when running the tests.
The issue was discovered in the initial push of #588
that passed the build phase, but failed the tests.
📚 Documentation preview 📚: https://datacube-explorer--596.org.readthedocs.build/en/596/