Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core library improvement #156

Open
lampajr opened this issue Nov 16, 2023 · 0 comments
Open

Core library improvement #156

lampajr opened this issue Nov 16, 2023 · 0 comments
Labels
chore Project management or other issues that are not a bug or feature request

Comments

@lampajr
Copy link
Contributor

lampajr commented Nov 16, 2023

As raised here:

  • check if we can get away without ZeroIfNil but dereference the pointer (I did not found a way at the time, since this snippet prints the address for instance:
	x := 123
	y := &x
	fmt.Printf("%v", y)

but we can keep the ZeroIfNil, this is just a minor check worth of doing

  • Check if we can refactor some of the methods, similarly to how it was done leveraging func mapTo[S getTypeIder, T any](s S, id int64, convFn func(S) (*T, error)) (*T, error)
@lampajr lampajr added the chore Project management or other issues that are not a bug or feature request label Nov 16, 2023
@lampajr lampajr mentioned this issue Nov 16, 2023
3 tasks
dhirajsb pushed a commit to dhirajsb/model-registry that referenced this issue Jan 20, 2025
…python (opendatahub-io#156)

Bumps [testcontainers](https://github.com/testcontainers/testcontainers-python) from 4.5.1 to 4.6.0.
- [Release notes](https://github.com/testcontainers/testcontainers-python/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-python/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-python@testcontainers-v4.5.1...testcontainers-v4.6.0)

---
updated-dependencies:
- dependency-name: testcontainers
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project management or other issues that are not a bug or feature request
Projects
Status: No status
Status: No status
Development

No branches or pull requests

1 participant