Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model-controller] Setup e2e tests for model registry and serving reconciliation #235

Open
lampajr opened this issue Dec 12, 2023 · 1 comment
Labels

Comments

@lampajr
Copy link
Contributor

lampajr commented Dec 12, 2023

Is your feature request related to a problem? Please describe.
In the first implementation of model registry and serving implemention we focused on creating unit testing by mocking the model registry service because the TestContainer approach was not feasible as it would not work in openshift-ci environment [1]. On the other hand having some ITs where we can actually test the connection to an existing model registry/ml-metadata service could be very helpful and furthermore we could setup real use cases in these tests.

[1] https://cloud.redhat.com/blog/running-testcontainers-in-openshift-pipelines-with-docker-in-docker

Describe the solution you'd like
Setup e2e test suite in odh-model-controller where we could setup model-registry service by directly applying a deployment and then run all expected tests.

Describe alternatives you've considered
Keep just unit tests, unfortunately we these we cannot cover all possible tests (especially those that writes on model registry are not really testable as we are mocking it)

Additional context
Some examples we could take inspiration from:

@lampajr
Copy link
Contributor Author

lampajr commented Dec 18, 2023

Investigating how to implement those e2e tests in the mode generic fashion, such that they will work regardless the infrastructure will actually run them (either openshift_ci or gha).

Tests assumption:

  • Kubernetes / Openshift cluster up and running.
  • The ODH model controller is deployed and running, this is responsability of the infrastructure to deploy it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant