Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

filetype remote is not set for extra resources #250

Open
AntoineAugusti opened this issue Sep 15, 2023 · 5 comments
Open

filetype remote is not set for extra resources #250

AntoineAugusti opened this issue Sep 15, 2023 · 5 comments

Comments

@AntoineAugusti
Copy link

def process_extra_files(self, dataset, data, data_type):

in this method, the filetype is not set which means that exports coming from ODS get assigned the wrong filetype (file).

On ODS: https://twisto.opendatasoft.com/explore/dataset/fichier-gtfs-du-reseau-twisto/export/
data.gouv.fr's API: https://www.data.gouv.fr/api/1/datasets/caen-la-mer-reseau-twisto-gtfs-siri/ resource ID is "291b778a-2c1f-43c5-a3fd-7e804ec01fbf"

@maudetes
Copy link
Contributor

Oh, seems true. It appears that filetype is also never set in DCAT harvesting: https://github.com/opendatateam/udata/blob/6f56467fc36fd54cf9ef7fec1fb4954f89141adc/udata/core/dataset/rdf.py#L393.
Not entirely sure of any side effect to change all harvested resources to remote though?

@AntoineAugusti
Copy link
Author

Not entirely sure of any side effect to change all harvested resources to remote though?

right, I'm not sure either.

This unfortunately caused a bug on our side because we handle remote/file differently in a few places so that's how I found it

@maudetes
Copy link
Contributor

Sorry for the delay. A fix is prepared for DCAT harvester (that should be used by ODS shortly): opendatateam/udata#2931

@maudetes maudetes moved this from 👀 Review to ✅ Done in 🚀 Produit data.gouv.fr [Archivé] Dec 1, 2023
@AntoineAugusti
Copy link
Author

@maudetes Thanks!

ODS harvester should be replaced by DCAT soon.

Could you share an expected release date in production when you will know it?

@maudetes
Copy link
Contributor

maudetes commented Dec 4, 2023

We're currently targeting the end of next week!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants