Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in cabinet notes are broken #1299

Open
rvtis opened this issue Jan 3, 2022 · 4 comments
Open

Links in cabinet notes are broken #1299

rvtis opened this issue Jan 3, 2022 · 4 comments

Comments

@rvtis
Copy link

rvtis commented Jan 3, 2022

what
Links in cabinet notes get broken every time you edit the cabinet, and get more broken with each edit. Each backwards slash multiplies by 10. Every time. 10, 100, 1000.

@wilpig
Copy link
Collaborator

wilpig commented Jan 3, 2022

Based on what I see in your screen shot you put in a path like L:\test\test.txt. While that can be used as a link, the sanitization process is not expecting such a link and is escaping the \ . I'll try to get some time to look into that process and see if it can be worked around.

@rvtis
Copy link
Author

rvtis commented Jan 4, 2022

Based on what I see in your screen shot you put in a path like L:\test\test.txt. While that can be used as a link, the sanitization process is not expecting such a link and is escaping the \ . I'll try to get some time to look into that process and see if it can be worked around.

Yes, that's a link to a folder.

@rvtis
Copy link
Author

rvtis commented Jan 14, 2022

Any updates?

@wilpig
Copy link
Collaborator

wilpig commented May 27, 2023

The fix is to change all the comments to markdown and it's more effort than I've been willing to put into it since that involves hacking at the data that's already stored and converting it from html to markdown, then simultaneously replacing the javascript everywhere and then testing to see what is going to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants