Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When candidate/primary/secondary return a content length of 0, Diffy returns empty 200 #97

Open
craigta opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@craigta
Copy link

craigta commented Sep 14, 2023

I'm seeing an empty 200 when downstream services are returning 401, which I also see reflected in the otel trace output. I'm also seeing that all my headers from the downstream services are dropped on the response in these cases as well

@puneetkhanduri puneetkhanduri self-assigned this Sep 19, 2023
@puneetkhanduri puneetkhanduri added the bug Something isn't working label Sep 19, 2023
@craigta
Copy link
Author

craigta commented Oct 19, 2023

Looking into this more, it is actually caused when the downstream services return an empty body aka content-length of 0. It looks like Diffy is returning a default set. Instead, Diffy should do the header comparison and return the primary HTTP status

@craigta craigta changed the title When candidate/primary/secondary return 401, Diffy returns 200 When candidate/primary/secondary return a content length of 0, Diffy returns empty 200 Oct 19, 2023
@jeffy-ifit
Copy link

jeffy-ifit commented Mar 18, 2024

Any resolution on this or is there a setting I can toggle? I believe I'm seeing the same thing when both primary and candidate are returning 204 with no body and diffy is instead returning 200

It seems this is caused primarily by the primary returning an empty body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants