Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vol-restore): added a doc for volume restore from a snapshot #156

Merged
merged 9 commits into from
Aug 31, 2023

Conversation

AJDatacore
Copy link
Contributor

No description provided.

Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to rebase the branch?

reference/snapshot-restore.md Show resolved Hide resolved
Signed-off-by: AJ_Datacore <[email protected]>
Signed-off-by: AJ_Datacore <[email protected]>
@Abhinandan-Purkait
Copy link
Member

Abhinandan-Purkait commented Aug 29, 2023

https://mayastor.gitbook.io/introduction/quickstart/configure-mayastor/storage-class-parameters

We need to add cloneFsIdAsVolumeId in the above section. The possible values can be true and false. If not specified its taken as false.

If this is enabled then, the created clone/restore's filesystem uuid would be set to the volume uuid. This feature is needed because filesystem like xfs doesn't allow duplicate filesystem uuid on the same machine by default.

If this is disabled then we would use the same uuid as that of the parent volume but, the mount would happen using nouuid flag which allows duplicate uuid.

The above is a gist of the description. @avishnu Can you please review this content and enhance/modify accordingly?

@avishnu
Copy link
Member

avishnu commented Aug 29, 2023

https://mayastor.gitbook.io/introduction/quickstart/configure-mayastor/storage-class-parameters

We need to add cloneFsIdAsVolumeId in the above section. The possible values can be true and false. If not specified its taken as false.

If this is enabled then, the created clone/restore's filesystem uuid would be set to the volume uuid. This feature is needed because filesystem like xfs doesn't allow duplicate filesystem uuid on the same machine by default.

If this is disabled then we would use the same uuid as that of the parent volume but, the mount would happen using nouuid flag which allows duplicate uuid.

The above is a gist of the description. @avishnu Can you please review this content and enhance/modify accordingly?

Content looks good. Minor change:

  • filesystems like XFS do not allow...
  • If this is disabled, the uuid of the original volume will be used for the restore filesystem as well, but the restore filesystem will be mounted using the nouuid flag to bypass the duplicate uuid validation.

Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AJDatacore AJDatacore merged commit 2251d57 into develop Aug 31, 2023
2 checks passed
@@ -23,6 +23,7 @@
* [Node Cordon](reference/node-cordon.md)
* [Node Drain](reference/node-drain.md)
* [Volume Snapshots](reference/snapshot.md)
* [Volume Restore from Snapshot](reference\snapshot.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be snapshot-restore.md?

@niladrih niladrih deleted the snapshot-restore-doc branch May 20, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants