ci: various release chart update fixes #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Dec 6, 2024
tiagolobocastro
commented
Don't update the chart on a pre-release Set missing base branch for pull-request Add stricter release validation Add more tests Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
abhilashshetty04 and
dsharma-dc
dsharma-dc
approved these changes
Dec 10, 2024
niladrih
reviewed
Dec 11, 2024
| die "Build not supported" | ||
| fi | ||
| if [ -n "$BRANCH" ]; then | ||
| if ! [[ "$BRANCH" =~ ^release/[0-9]+.[0-9]+$ ]]; then |
There was a problem hiding this comment.
Suggested change
| if ! [[ "$BRANCH" =~ ^release/[0-9]+.[0-9]+$ ]]; then | |
| if ! [[ "$BRANCH" =~ ^(release/[0-9]+.[0-9]+)$ ]]; then |
There was a problem hiding this comment.
We're not capturing groups here, so there's no need for that? Or is there another reason I'm unaware of?
A GitHub action bumps the release version on Chart.yaml on release but it's failing on pre-releases. |
Abhinandan-Purkait
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.