refactor(upgrade): expose modules to pub scope #580
Conversation
niladrih
requested review from
tiagolobocastro,
sinhaashish,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
Signed-off-by: Niladri Halder <[email protected]>
| self.base.deprecated_log_silence_level() | ||
| } | ||
|
|
||
| pub(crate) fn jaeger_operator_image_tag(&self) -> &str { | ||
| pub fn jaeger_operator_image_tag(&self) -> &str { |
There was a problem hiding this comment.
missing doc comment
There was a problem hiding this comment.
I'll add in all of these missing doc comments.
| @@ -52,7 +52,7 @@ pub(crate) fn version_from_core_chart_release(chart_name: &str) -> Result<Versio | |||
| }) | |||
| } | |||
|
|
|||
| pub(crate) async fn core_version_from_umbrella_release( | |||
| pub async fn core_version_from_umbrella_release( | |||
There was a problem hiding this comment.
Missing doc comment
This is for the unified plugin, which will be a new binary. |
Does it need this big public api surface exposed or can we expose minimal api and leave internal details here? |
Hmm... sure, I'll trim this down. All of this doesn't need to be in pub scope. 👍 |
This is a refactor which moves most of the upgrade-job 'bin' code to the upgrade lib, and expands its visibility scope from 'pub(crate)' to 'pub'.