chore: fix helm-testing versioning in publish-chart-yaml #584
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hard coded patch and minor values of 0, with values derived from the chart version That way we get versions derived from chart/Chart.yaml, like 2.7.2-... instead of hard coded values like 2.7.0-... or 2.0.0-.... Signed-off-by: Blaise Dias <[email protected]>
blaisedias
requested review from
tiagolobocastro,
Abhinandan-Purkait and
niladrih
Abhinandan-Purkait
approved these changes
Dec 11, 2024
tiagolobocastro
approved these changes
Dec 11, 2024
niladrih
approved these changes
Dec 11, 2024
|
bors merge |
|
Build succeeded: |
bors-openebs-mayastor
bot
deleted the
helm-testing-version-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix helm testing version generation
Description
Replace hard coded patch and minor values of 0,
with values derived from the chart version
That way we get versions derived from chart/Chart.yaml, like 2.7.2-... instead of hard coded values like 2.7.0-... or 2.0.0-....
Motivation and Context
This change is required to build with version numbers that monotonically increase
This makes is possible to test upgrades with setting override flags.
Regression
Is this PR fixing a regression? No
How Has This Been Tested?
tested by executing the modified script using the command line
Types of changes
Checklist: