Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rdma): add e2e agent capability to enable and disable network interface #85

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat(rdma): add e2e agent capability to enable and disable network interface #85

merged 1 commit into from
Oct 23, 2024

Conversation

rohan2794
Copy link
Collaborator

No description provided.

blaisedias
blaisedias reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@blaisedias blaisedias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this will work with any network interface.
So, please can we de-couple the use of rdma structs for this functionality.
We should use generic structs for this purpose.

@rohan2794
Copy link
Collaborator Author

IIUC this will work with any network interface. So, please can we de-couple the use of rdma structs for this functionality. We should use generic structs for this purpose.

@blaisedias Should i use NodeList struct in place of Rdma struct ?

@rohan2794 rohan2794 force-pushed the enable-disable-iface branch 2 times, most recently from 50e48c2 to 3f56ef7 Compare October 22, 2024 09:23
@rohan2794
Copy link
Collaborator Author

IIUC this will work with any network interface. So, please can we de-couple the use of rdma structs for this functionality. We should use generic structs for this purpose.

moved to generic struct https://github.com/openebs/openebs-e2e/compare/ecb5f8f53236abf695573c73a2d827e4ab181343..50e48c260291870c2df8ec06f953854db14c833a

@rohan2794 rohan2794 force-pushed the enable-disable-iface branch from 3f56ef7 to 283344e Compare October 23, 2024 05:24
@rohan2794 rohan2794 merged commit b1d0174 into develop Oct 23, 2024
2 checks passed
@rohan2794 rohan2794 deleted the enable-disable-iface branch October 23, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w3aman w3aman w3aman approved these changes

@blaisedias blaisedias blaisedias approved these changes

@r1jt r1jt Awaiting requested review from r1jt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan2794 @blaisedias @w3aman